Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the chore model #36

Merged
merged 2 commits into from Jan 2, 2023
Merged

added the chore model #36

merged 2 commits into from Jan 2, 2023

Conversation

EliasAndry
Copy link
Collaborator

@EliasAndry EliasAndry commented Dec 1, 2022 •
edited

site is almost ready.. and the chore model aswell
might need some changes if we wanna add more pages or other things..

issue #22

FaezZangariya
FaezZangariya previously approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@FaezZangariya FaezZangariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bennypowers
bennypowers reviewed Dec 26, 2022
View reviewed changes
commune_app/models.py Outdated Show resolved Hide resolved
bennypowers
bennypowers requested changes Dec 26, 2022
View reviewed changes
commune_app/templates/commune_app/index.html Show resolved Hide resolved
commune_app/templates/commune_app/chores.html Outdated Show resolved Hide resolved
commune_app/templates/commune_app/chores.html Outdated Show resolved Hide resolved
commune_app/templates/commune_app/index.html Outdated Show resolved Hide resolved
static/css/style.css Show resolved Hide resolved
static/css/style.css Show resolved Hide resolved
kobihk
kobihk requested changes Dec 26, 2022
View reviewed changes
commune_app/models.py Outdated Show resolved Hide resolved
commune_app/templates/commune_app/chores.html Outdated Show resolved Hide resolved
static/css/style.css Outdated Show resolved Hide resolved
@FaezZangariya
Copy link
Collaborator

I need you to please add a boolean variable called passed to the model and a static method that returns a chore by id, I need those for the Vote model

ofirtzabari
ofirtzabari previously approved these changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@ofirtzabari ofirtzabari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only the comments of the mentors
everything else looks good

kobihk
kobihk requested changes Dec 27, 2022
View reviewed changes
commune/settings.py Outdated Show resolved Hide resolved
@kobihk kobihk mentioned this pull request Dec 28, 2022
Merged
@EliasAndry
Copy link
Collaborator Author

I need you to please add a boolean variable called passed to the model and a static method that returns a chore by id, I need those for the Vote model

done added the passed field and static method.

kobihk
kobihk requested changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@kobihk kobihk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EliasAndry in the code I can see that you added menu but when I run the vagrant I can't see the menu.
Please check it

commune_app/all_models/chores.py Outdated Show resolved Hide resolved
commune_app/all_models/chores.py Outdated Show resolved Hide resolved
commune_app/all_models/chores.py Show resolved Hide resolved
commune_app/all_models/chores.py Outdated Show resolved Hide resolved
commune_app/all_models/chores.py Outdated Show resolved Hide resolved
commune_app/migrations/0001_initial.py Outdated Show resolved Hide resolved
commune_app/templates/commune_app/chores.html Outdated Show resolved Hide resolved
commune_app/tests/test_chores.py Outdated Show resolved Hide resolved
commune_app/tests/test_chores.py Outdated Show resolved Hide resolved
kobihk
kobihk requested changes Dec 29, 2022
View reviewed changes
commune_app/all_models/chores.py Outdated Show resolved Hide resolved
commune_app/migrations/0001_initial.py Outdated Show resolved Hide resolved
commune_app/tests/test_chores.py Outdated Show resolved Hide resolved
commune_app/tests/test_chores.py Outdated Show resolved Hide resolved
commune_app/tests/test_chores.py Outdated Show resolved Hide resolved
bennypowers
bennypowers previously approved these changes Jan 2, 2023
View reviewed changes
@EliasAndry EliasAndry changed the title added the choremodel added the chore model Jan 2, 2023
@EliasAndry EliasAndry requested a review from kobihk January 2, 2023 11:20
@ofirtzabari
Copy link
Collaborator

@kobihk @EliasAndry
I added this migration file in my PR
I prefer that they follow what I did because for me it is a little different and it is linked to other files
look in PR #52 #53

@kobihk kobihk merged commit 6d86f8a into redhat-beyond:main Jan 2, 2023
@kobihk
Copy link
Contributor

kobihk commented Jan 2, 2023

@kobihk @EliasAndry I added this migration file in my PR I prefer that they follow what I did because for me it is a little different and it is linked to other files look in PR #52 #53
@ofirtzabari I prefer not to waste more time on this PR
please rebase on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofirtzabari ofirtzabari ofirtzabari left review comments

@kobihk kobihk kobihk approved these changes

@NicolePauzner NicolePauzner NicolePauzner approved these changes

@FaezZangariya FaezZangariya FaezZangariya approved these changes

@bennypowers bennypowers bennypowers left review comments

@RonTuretzky RonTuretzky Awaiting requested review from RonTuretzky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@EliasAndry @FaezZangariya @ofirtzabari @kobihk @bennypowers @NicolePauzner