Adding Vote model #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaezZangariya
requested review from
kobihk,
RonTuretzky,
NicolePauzner,
bennypowers,
EliasAndry and
ofirtzabari
NicolePauzner
previously approved these changes
Dec 28, 2022
kobihk
requested changes
Dec 28, 2022
FaezZangariya
dismissed stale reviews from NicolePauzner and ofirtzabari
via
794f212
kobihk
requested changes
Dec 29, 2022
kobihk
requested changes
Jan 1, 2023
|
@FaezZangariya please rebase and resolve the conflicts |
RonTuretzky
previously approved these changes
Jan 3, 2023
kobihk
requested changes
Jan 3, 2023
RonTuretzky
previously approved these changes
Jan 3, 2023
EliasAndry
previously approved these changes
Jan 3, 2023
ofirtzabari
previously approved these changes
Jan 3, 2023
FaezZangariya
dismissed stale reviews from ofirtzabari and EliasAndry
via
9690910
no tests yet , i need a boolean variable called passed in chore model and a method that returns a chore by id , also i need a method that returns the number of members in the commune in commune model Signed-off-by: faezzangariya <faezzangariyacs@gmail.com>
i will be adding more tests and switching from fixtures to a migration test files later on Signed-off-by: faezzangariya <faezzangariyacs@gmail.com> Registering to admin
RonTuretzky
approved these changes
Jan 3, 2023
kobihk
approved these changes
Jan 3, 2023
ofirtzabari
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no tests yet , i need a boolean variable called passed in chore model and a method that returns a chore by id , also i need a method that returns the number of members in the commune in commune model
Signed-off-by: faezzangariya faezzangariyacs@gmail.com