Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto add users #52

Merged
merged 4 commits into from Jan 3, 2023
Merged

Auto add users #52

merged 4 commits into from Jan 3, 2023

Conversation

ofirtzabari
Copy link
Collaborator

@ofirtzabari ofirtzabari commented Jan 2, 2023 •
edited

create migrations file that auto add users when the app start to run.
close issue #51

bennypowers
bennypowers previously approved these changes Jan 2, 2023
View reviewed changes
kobihk
kobihk requested changes Jan 2, 2023
View reviewed changes
commune_app/migrations/0002_add_user_test_data.py Outdated Show resolved Hide resolved
commune_app/migrations/0002_add_user_test_data.py Outdated Show resolved Hide resolved
commune_app/migrations/0002_add_user_test_data.py Outdated Show resolved Hide resolved
@kobihk
Copy link
Contributor

kobihk commented Jan 2, 2023

create migrations file that auto add users when the app start to run close issue #51

please update the description of this PR to something like this:
create a migrations file that auto add users when the app starts to run.
fixed issue #51

@ofirtzabari ofirtzabari mentioned this pull request Jan 2, 2023
Merged
@kobihk kobihk mentioned this pull request Jan 2, 2023
Merged
kobihk
kobihk requested changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@kobihk kobihk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofirtzabari please rebase

@ofirtzabari
Auto add users
ebe6050 
create migrations file that auto add users when the app start to run
close issue redhat-beyond#51
@ofirtzabari
fix change request
8a15faf
@ofirtzabari
Add migrations file
d1ad842 
add missing migrations and migrate them (file 0003)
@ofirtzabari
rebase by main
eff0d81 
Adjusting the files according to the main
@ofirtzabari
Copy link
Collaborator Author

@ofirtzabari please rebase

done

RonTuretzky
RonTuretzky reviewed Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@RonTuretzky RonTuretzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobihk kobihk merged commit 99ea897 into redhat-beyond:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobihk kobihk kobihk approved these changes

@NicolePauzner NicolePauzner NicolePauzner approved these changes

@RonTuretzky RonTuretzky RonTuretzky approved these changes

@EliasAndry EliasAndry Awaiting requested review from EliasAndry

@FaezZangariya FaezZangariya Awaiting requested review from FaezZangariya

@bennypowers bennypowers Awaiting requested review from bennypowers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ofirtzabari @kobihk @bennypowers @NicolePauzner @RonTuretzky