Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove output folder from source #86

Merged
merged 2 commits into from Feb 13, 2023
Merged

Remove output folder from source #86

merged 2 commits into from Feb 13, 2023

Conversation

Fale
Copy link
Contributor

@Fale Fale commented Feb 8, 2023

The docs folder contains the HTML version of the document.

This folder should never be checked out (hence it should be in the /gitignore file).
Though, we need it to be present while creating the documentation (hence it should be created in the release and in the preview targets in the Makefile).
Also, the github release pipeline should create it (in the docs branch), hence the --force to the git add command in the release pipeline.

The `docs` folder contains the HTML version of the document.
This folder should never be checked out (hence it should be in the `/gitignore` file).
Though, we need it to be present while creating the documentation (hence it should be created in the `release` and in the `preview` targets in the `Makefile`).
Also, the github release pipeline should create it (in the `docs` branch), hence the `--force` to the `git add` command in the release pipeline.
Copy link
Contributor

@mophahr mophahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mophahr
Copy link
Contributor

mophahr commented Feb 8, 2023

Approved in CoP meeting

@Fale Fale mentioned this pull request Feb 8, 2023
@mophahr mophahr merged commit 5f989f0 into redhat-cop:main Feb 13, 2023
@Fale Fale deleted the cb branch March 2, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants