From ec344c12db04e84ed0d578ec6a6d93b6f342dee5 Mon Sep 17 00:00:00 2001 From: Denis Golovin Date: Mon, 18 Apr 2016 18:37:58 -0700 Subject: [PATCH] JBDS-3838 Cannot install CDK Use current process environment instead new one --- browser/model/cdk.js | 8 ++++---- test/unit/model/cdk-test.js | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/browser/model/cdk.js b/browser/model/cdk.js index cb97bb0d..20b20dca 100644 --- a/browser/model/cdk.js +++ b/browser/model/cdk.js @@ -175,14 +175,14 @@ class CDKInstall extends InstallableItem { } createEnvironment() { - let env = {}; - - //TODO Need to get this info from VagrantInstaller rather than hard code + let env = process.env; let vagrantInstall = this.installerDataSvc.getInstallable('vagrant'); let vboxInstall = this.installerDataSvc.getInstallable('virtualbox'); let vgrPath = vagrantInstall.getLocation(); let vboxPath = vboxInstall.getLocation(); - env['path'] = path.join(vgrPath,'bin') + ';' + vboxPath + ';'; + env['path'] = env['path'] + + path.delimiter + path.join(vgrPath,'bin') + + path.delimiter + vboxPath; return env; } diff --git a/test/unit/model/cdk-test.js b/test/unit/model/cdk-test.js index 3f26e9e2..02aa47b8 100644 --- a/test/unit/model/cdk-test.js +++ b/test/unit/model/cdk-test.js @@ -198,10 +198,10 @@ describe('CDK installer', function() { expect(spy).calledWith(installer.cdkDownloadedFile, installerDataSvc.installDir()); }); - it('createEnvironment should return path to vagrant/bin', function() { + it('createEnvironment should return path with vagrant/bin', function() { let installer = new CDKInstall(installerDataSvc, 900, cdkUrl, cdkBoxUrl, ocUrl, pscpUrl, null); let env = installer.createEnvironment(); - expect(env['path']).equal(path.join(installerDataSvc.vagrantDir(), 'bin') + ';' + installerDataSvc.vagrantDir() + ';'); + expect(env['path']).includes(path.join(installerDataSvc.vagrantDir(), 'bin') + path.delimiter + installerDataSvc.vagrantDir()); }); it('setupVagrant should wait for vagrant install to complete', function() {