Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse angular 2+ http service or fetch API to download files to use browser and OS proxy settings #1052
Comments
dgolovin
self-assigned this
Nov 22, 2017
dgolovin
added
the
kind/enhancement
label
Dec 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dgolovin commentedNov 22, 2017
•
edited
Now installer uses request node module to download resources and send http requests. It does not use OS and browser proxy settings by default and therefore to work behind proxy manually setting HTTPS_PROXY env variable is required.
Here is fixed example from https://damieng.com/blog/2017/03/10/downloading-files-with-progress-in-electron that uses fetch API https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch to download files.
fetch API though required to implement custom timeout and request termination.