Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upLoss of window focus causes duplicate check for installed components #1094
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dgolovin
Dec 6, 2017
Contributor
Thank you for reporting this problem. It is working as intended and was originally added to address specific use cases. For example, let's say you have old Virtualbox version detected, that would not work with CDK. Installer would not let you continue with CDK installation until this issue is fixed by removing it. You would switch to control panel and uninstall Virtualbox. On returning to installer window detection is triggered, no Virtualbox is detected and you can continue with installation.
It turned out detection is very slow on windows specifically for OpenJDK installation. we are planning to address this issue by making duplicate check for installed components extremely fast. It would just check if components detected on first check where removed during the time installer window lost its focus. That would cover use case above and make secon detection run barely noticeable.
|
Thank you for reporting this problem. It is working as intended and was originally added to address specific use cases. For example, let's say you have old Virtualbox version detected, that would not work with CDK. Installer would not let you continue with CDK installation until this issue is fixed by removing it. You would switch to control panel and uninstall Virtualbox. On returning to installer window detection is triggered, no Virtualbox is detected and you can continue with installation. It turned out detection is very slow on windows specifically for OpenJDK installation. we are planning to address this issue by making duplicate check for installed components extremely fast. It would just check if components detected on first check where removed during the time installer window lost its focus. That would cover use case above and make secon detection run barely noticeable. |
dgolovin
self-assigned this
Dec 6, 2017
dgolovin
added
the
kind/bug
label
Dec 6, 2017
dgolovin
added this to the 2.2.0-GA milestone
Dec 6, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dgolovin
Dec 8, 2017
Contributor
This is also reported here https://issues.jboss.org/browse/JBDS-4402.
|
This is also reported here https://issues.jboss.org/browse/JBDS-4402. |
dgolovin
added this to Planned
in devex #142 December 2017
Dec 13, 2017
dgolovin
removed this from Planned
in devex #142 December 2017
Jan 4, 2018
dgolovin
added this to To do
in devex #143 January 2018
Jan 4, 2018
dgolovin
modified the milestones:
2.2.0-GA,
2.3.0-GA
Jan 16, 2018
dgolovin
removed this from To do
in devex #143 January 2018
Jan 16, 2018
dgolovin
added this to To Do
in devex #144 February 2018
via automation
Jan 16, 2018
dgolovin
removed this from To Do
in devex #144 February 2018
Feb 14, 2018
dgolovin
added this to To do
in devex #145 February 2018
via automation
Feb 14, 2018
dgolovin
added this to To do
in devex #146 March 2018
via automation
Mar 7, 2018
dgolovin
removed this from To do
in devex #145 February 2018
Mar 7, 2018
dgolovin
added
the
priority/major
label
Mar 7, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dgolovin
Mar 28, 2018
Contributor
Detection performance was improved, now after window lost and got focus back, detection takes less than second.
|
Detection performance was improved, now after window lost and got focus back, detection takes less than second. |
robin-owen commentedDec 5, 2017
I'm not sure if this is working as intended or if this is a bug.
On Windows 10, if the installer loses focus for any reason (tested using the Windows start menu, alt+tab window switching, and clicking on the desktop), the installer will re-run the check for already-installed components.
The only use case I can personally think of where this would be desired is if a component happens to be installed while the installer itself is running -- this seems rather unlikely. It's far more likely that the user will lose focus for some other reason and have to come back to the installer to have it run a check that it has already run before.
Note that this check will occur as often as focus on the window is lost and then regained.