-
Notifications
You must be signed in to change notification settings - Fork 12
Add Application Detail Pages and Tabs (#7267) #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Application Detail Pages and Tabs (#7267) #108
Conversation
Signed-off-by: Keith Chong <kykchong@redhat.com>
dbf2b8a to
7e17f29
Compare
| k8sUpdate({ | ||
| model: ApplicationModel, | ||
| data: obj, | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be add try-catch and user feedback for the users to know why it failed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add a modal popup to show the message
|
duplicate header under YAML tab gitops-console-plugin/src/gitops/components/shared/ResourceYAMLTab/ResourceYAMLTab.tsx Line 26 in 7e17f29
|
|
The current Application details page has all the application-specific information stacked in the right column. |
Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
aali309
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Keith.
|
Thanks @aali309 . Merged. |


See GITOPS-7267
This adds the Details Page for Applications. The details page consists of 7 tabs
Details, YAML, Sources, Resources, Sync Status, History, Events
I tested it with a variety of applications, including multi-source apps, and helm
