fix: AppSet's list of applications tab shows incorrect number of apps in the filter #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithchong
reviewed
Nov 15, 2025
Collaborator
keithchong
left a comment
keithchong
left a comment
There was a problem hiding this comment.
It's better....but the selected filter or filter items do not work still.
aali309
force-pushed
the
fixGeneratedAppsSorting
branch
from
7f69a02 to
4f820ba
Compare
… in the filter Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
aali309
force-pushed
the
fixGeneratedAppsSorting
branch
from
c759808 to
47b5685
Compare
keithchong
approved these changes
Dec 1, 2025
Collaborator
keithchong
left a comment
keithchong
left a comment
There was a problem hiding this comment.
Looks good @aali309 . Filter numbers are accurate now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: GITOPS-8143