feat: Rollouts in Topology View (#5872, #5873, #5874, #6978) #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithchong
force-pushed
the
5872-5873-5874-6978-PatternFlyUpgrade-TopologySupport
branch
from
9cadbe2 to
1b02a7d
Compare
Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
force-pushed
the
5872-5873-5874-6978-PatternFlyUpgrade-TopologySupport
branch
from
1b02a7d to
4016e63
Compare
aali309
reviewed
Jun 13, 2025
Collaborator
aali309
left a comment
aali309
left a comment
There was a problem hiding this comment.
we could add some error handling in some of the files, Other than that the code is well structured and LGTM!
Collaborator
|
This is great! LGTM! 🚀 
|
aali309
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for Rollouts in Topology View
Fixes https://issues.redhat.com/browse/GITOPS-5872, https://issues.redhat.com/browse/GITOPS-5873, https://issues.redhat.com/browse/GITOPS-5874, https://issues.redhat.com/browse/GITOPS-6978
Includes required changes to depend on the 4.19.0-prerelease.2 version of the dynamic plugin SDK and PatternFly 6