Skip to content

feat: Rollouts: Implement Delete Action (#7127) #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

feat: Rollouts: Implement Delete Action (#7127) #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/components/topology/actions/action-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import * as React from 'react';

import { Action } from '@openshift-console/dynamic-plugin-sdk';
import { Action, useDeleteModal } from '@openshift-console/dynamic-plugin-sdk';
import { getResource } from '@openshift-console/dynamic-plugin-sdk-internal';
import { GraphElement, isGraph } from '@patternfly/react-topology';

import { editRollout } from './creators';
import { editRollout, getDeleteRolloutAction } from './creators';

export const useGitOpsActionProviderForTopology = (element: GraphElement) => {
const resource = getResource(element);
const deleteModal = useDeleteModal(resource);

const actions = React.useMemo(() => {
const resource = getResource(element);
if (!resource) {
return [];
}
Expand All @@ -17,10 +19,10 @@ export const useGitOpsActionProviderForTopology = (element: GraphElement) => {
}
const addActions: Action[] = [];
addActions.push(editRollout(resource));
// addActions.push(getDeleteRolloutAction(resource)) // Add Delete action later
addActions.push(getDeleteRolloutAction(deleteModal));
// Look at console/frontend/packages/dev-console/src/actions/add-resources.tsx : disabledActionsFilter
return addActions;
}, [element]);
}, [element, resource, deleteModal]);
return [actions, true, undefined];
};
const TYPE_APPLICATION_GROUP = 'part-of';
Expand Down
20 changes: 2 additions & 18 deletions src/components/topology/actions/creators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,10 @@
import { Action, K8sResourceKind } from '@openshift-console/dynamic-plugin-sdk';

export const getDeleteRolloutAction = (obj: K8sResourceKind): Action => ({
export const getDeleteRolloutAction = (deleteModal: () => void): Action => ({
id: 'delete-rollout',
label: 'Delete Rollout',
cta: () => {
console.log('GitOps: DeleteRolloutAction disabled for ' + obj?.metadata?.name);
// Dependency on console. We need to implement later
// deleteResourceModal({
// blocking: true,
// resourceName: rollout,
// resourceType: 'Rollout',
// actionLabel: t('Delete'),
// redirect,
// onSubmit: () => {
// return coFetchJSON.delete(
// `/api/helm/release/async?name=${releaseName}&ns=${namespace}&version=${releaseVersion}`,
// null,
// null,
// -1,
// );
// },
// });
deleteModal();
},
});

Expand Down