Skip to content

Conversation

@TomerFi
Copy link
Collaborator

@TomerFi TomerFi commented Mar 24, 2023

No description provided.

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 24, 2023

@jeffmaury looks like I don't have permissions to view our snyk's organization.
can you please provide information about the CI failure?

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 27, 2023

/hold

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 27, 2023

Version 0.95.1 introduced a bug.
Opening files doesn't trigger diagnostics.
Details in #107

@TomerFi TomerFi force-pushed the fix-lsp-server-errors branch from 6fe996f to 46fac5e Compare March 27, 2023 08:36
@TomerFi TomerFi changed the title chore: pinned lsp4intellij to latest 0.95.1 build(deps): pin lsp4intellij to version 0.95.0 Mar 27, 2023
@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 27, 2023

/unhold

@TomerFi TomerFi force-pushed the fix-lsp-server-errors branch 2 times, most recently from a082a44 to 3608666 Compare March 27, 2023 09:35
@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 27, 2023

@jeffmaury
Testing locally with Snyk's CLI shows that adding the constraints for com.google.guava:guava:30.0-jre and com.google.code.gson:gson:2.8.9 resolves the vulnerability issues reported by Snyk.

I'm not quite sure why does Snyk's CI still shows the same vulnerabilities for the same dependency versions.

Can you please help figuring this out?

I can't dont have enough time to assign to this project

@TomerFi TomerFi force-pushed the fix-lsp-server-errors branch from 3608666 to 1c66e40 Compare March 27, 2023 15:09
@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 27, 2023

I can't dont have enough time to assign to this project

@jeffmaury Seeing that testing with Snyk CLI reports this vulnerabilities issue was resolved after I added the constraints, I'm going to click the button in Snyk's test for marking this test successful.

version 0.95.1 broke diagnostics for opening files.

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
@TomerFi TomerFi force-pushed the fix-lsp-server-errors branch from 1c66e40 to 29f2c4a Compare March 28, 2023 06:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 28, 2023

rebased from the master after previous prs merged.

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 28, 2023

Displaying how Snyk's CLI reports the vulnerabilities in the main branch but not on the fixed branch containing the dependency constraints:

intellij-plugin-snyk

This gif was made with my personal token and not my Red Hat one for brevity.

Using my Red Hat token and pointing to our organization (--org="redhat-developer") makes the cli include license policies in its test, which only appear when using the CLI, its not included while using CI for organizations without a paid plan:
image

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 28, 2023

A git diff between the fixed and main branches showing the dependency constraints made to resolve the vulnerabilities issue:

image

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 28, 2023

A snapshot from Snyk's test page still reporting the vulnerabilities:

image

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 28, 2023

Based on the images I provided above this comment proving this branch has no vulnerabilities reported, I'm marking this false-positive test manually as successful in Snyk's UI:
image

@TomerFi TomerFi merged commit b24697b into redhat-developer:main Apr 14, 2023
@TomerFi
Copy link
Collaborator Author

TomerFi commented Apr 14, 2023

relates to #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants