-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Stack Analysis implementation in Dependency Analytics Intellij plugin #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @jeffmaury, kindly review this PR. |
src/main/java/org/jboss/tools/intellij/analytics/GitHubReleaseDownloader.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/analytics/PreloadLanguageServer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jboss/tools/intellij/analytics/SaProcessExecutor.java
Outdated
Show resolved
Hide resolved
7ab9b9b to
ec9a22f
Compare
|
Hello @jeffmaury, all comments are addressed PTAL. |
jeffmaury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
A few remarks:
- maybe worth to put code specific to the stack analysis in a separate package rather that in the root package
- would be good if the editor tab displays the original file name in the addition of "Dependency Analytics Report"
- you added a new JSON library I think IJ already provides some
|
Sure @jeffmaury I will address your comments
|
|
|
@jeffmaury So are you ok with the approach? |
yes, waiting for the few changes and merge would follow :) |
1e5beb4 to
6f55a53
Compare
|
Hello @jeffmaury, I addressed your comments about Editor Tab name and individual package. Could not address the one about JSON library, I looked for it, IJ has one inbuilt but it is available in IDEA Ultimate only. PTAL |
|
I can find Google GSON and Jackson as part of the IC library |
Yes, you are right, JSON library is there, I was searching for it at a wrong place. I have changed it. PTAL. |
src/main/java/org/jboss/tools/intellij/stackanalysis/SaUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: jparsai <jparsai@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Are we good to merge now @jparsai ?
Yes @jeffmaury, Please merge it. |
|
Congrats @jparsai, great work. |
|
Thank you @jeffmaury for you support and guidance. |








Description
This PR is to introduce Stack Analysis capabilities of CRDA platform into existing Intellij Plugin of CRDA.
Documentation
Approach document:- https://docs.google.com/document/d/1dBq4bVlg_r0D7Fp_xu57JepixE2EseNP9hE-Es7fMz8/edit?usp=sharing
Sequence diagram for process after plugin installation/IDE restart:- https://drive.google.com/file/d/1GVwyGnZR6KOSfYEYhhOVCJEc7lhxvBn5/view?usp=sharing
Sequence diagram for process to execution Stack Analysis on demand:- https://drive.google.com/file/d/1RmFZxadK0rfbG-mbCyelAyxt_-xZaWyl/view?usp=sharing
Type of changes in existing files
Readme:- Updated details about plugin.
build.gradle:- Upgraded Intellij plugin version.
Added new dependencies.
gradle.properties:- Bumped up lowest supported IDE version due to JCEF loading issue in 2020.2 and 2020.3 versions of Intellij.
GitHubRelease.java:- Downloading assets using name instead of label, as CLI releases are not having any label attached, downloading using name is not causing any issue in LSP download as well.
GitHubReleaseDownloader.java:- Modified logic to download file based on type (LSP or CLI) instead of introducing new class to download CLI.
ICookie.java:- Added new cookie for CLI.
Platform.java:- Introduced new methods/variables for CLI.
PreloadLanguageServer.java:- Sending repo name as an argument in GitHubReleaseDownloader() because now it is being used for CLI repo as well.
plugin.xml:- Updated plugin description which is shown in Marketplace page.
Updated build version because we need to use 2021.x + versions of IDE due to JCEF issue.
Added preloadingActivity, fileEditorProvider and set of Actions.