-
Notifications
You must be signed in to change notification settings - Fork 22
fix: intelliJ 2022.3 breaking plugin + lsp server exceptions #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
look like the GHReleaseDownloader is not used, it functionality is delivered by GitHubRelease and GitHubReleaseDownloader. Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
…ed by value Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
… usage Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
|
@jeffmaury please review this when you're available. |
|
Too much unrelated stuff in one plugin.Please split per concern: one commit = one PR |
|
I respectfully disagree. Unless we have a technical requirement for that. Then this can be achieved by doing Rebase+Merge. This is a small PR, I don't see value in converting it to 8 PRs. Please let me know your decision. |
|
It's not a matter of merging/rebasing but this is how we work together. The policy on this project has been to provider one PR per concern/issue, please adapt. |
|
Let's agree to disagree on this. Regardless, if this is how you prefer to work on this project, I'll split this into 8 PRs, no problem at all. Thank you. |








Usually I prefer smaller PRs, but this one had to include multiple modifications to make everything work well.
Worth noting:
view docs
view article
view docs
Tested locally with versions: