Skip to content

Conversation

@TomerFi
Copy link
Collaborator

@TomerFi TomerFi commented Mar 24, 2023

Usually I prefer smaller PRs, but this one had to include multiple modifications to make everything work well.

Closes #79, Closes #89 
Fixes #76, Fixes #81, Fixes #91, Fixes #92 

Worth noting:

  • Bump IntelliJ plugin version to 1.13.2 based on docs recommendation.
    view docs
  • Bump Java version to 11, we target intellij version to major 2021.1 which have been migrated to java 11.
    view article
  • Storage configuration, file has been deprecated and replaced by value.
    view docs

Tested locally with versions:

  • 2021.1 (our minimum target)
  • 2022.2
  • 2022.3 (the latest version)

TomerFi added 8 commits March 24, 2023 10:47
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
look like the GHReleaseDownloader is not used, it functionality is
delivered by GitHubRelease and GitHubReleaseDownloader.

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
…ed by value

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
… usage

Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@TomerFi TomerFi changed the title Fix for IntelliJ 2022.3 breaking plugin fix intelliJ 2022.3 breaking plugin + lsp server exceptions Mar 24, 2023
@TomerFi TomerFi changed the title fix intelliJ 2022.3 breaking plugin + lsp server exceptions fix: intelliJ 2022.3 breaking plugin + lsp server exceptions Mar 24, 2023
@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 24, 2023

@jeffmaury please review this when you're available.

@jeffmaury
Copy link
Member

Too much unrelated stuff in one plugin.Please split per concern: one commit = one PR

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 24, 2023

I respectfully disagree.

Unless we have a technical requirement for that. Then this can be achieved by doing Rebase+Merge.

This is a small PR, I don't see value in converting it to 8 PRs.
But if it's a blocker for you as the repository maintainer, I'll do it.

Please let me know your decision.
Thank you.

@jeffmaury
Copy link
Member

It's not a matter of merging/rebasing but this is how we work together. The policy on this project has been to provider one PR per concern/issue, please adapt.

@TomerFi
Copy link
Collaborator Author

TomerFi commented Mar 24, 2023

Let's agree to disagree on this.

Regardless, if this is how you prefer to work on this project, I'll split this into 8 PRs, no problem at all.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants