fix: Editor is already disposed in LSP hover operation (#914) #924
Conversation
|
As IJ hover provider API doesn't provide the target offset (it provies the hovered PsiElement), the master code defines the getCursorOffset https://github.com/redhat-developer/intellij-quarkus/pull/924/files#diff-3226f92e605d133b246286d765a9045cc993a8fc0804b4ef662b3d6403639857L121 which uses invokeLater https://github.com/redhat-developer/intellij-quarkus/pull/924/files#diff-3226f92e605d133b246286d765a9045cc993a8fc0804b4ef662b3d6403639857L123 The main idea of this PR is to remove thisCompletableFuture which get the cursor. To remove rhis getCursorOffet, the idea is to implement https://github.com/redhat-developer/intellij-quarkus/pull/924/files#diff-3226f92e605d133b246286d765a9045cc993a8fc0804b4ef662b3d6403639857L123 to get the target offset. |
| } | ||
|
|
||
| @Nullable | ||
| @Override | ||
| public String generateDoc(PsiElement element, @Nullable PsiElement originalElement) { | ||
| Editor editor = LSPIJUtils.editorForElement(element); | ||
| if (editor != null) { | ||
| initiateHoverRequest(element, editor); |
There was a problem hiding this comment.
can't you use int offset = PsiUtilCore.getElementOffsetInFile(element); instead ?
There was a problem hiding this comment.
Hover should work without PsiElement to avoid client to implement a Psi parser. We need just the hovered offset and we don't use PsiElement.
angelozerr
force-pushed
the
texthover-improve-cursoroffset
branch
3 times, most recently
from
4a93a99
to
2e3d776
Compare
…per#914) Fixes redhat-developer#914 Signed-off-by: azerr <azerr@redhat.com>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@fbricon are you agree with my changes? I would like to include this PR in the release |
|
LGTM |
|
Thanks @angelozerr! |
fix: Editor is already disposed in LSP hover operation (#914)
Fixes #914