fix(scorecard): use resolveMetricTranslation in drilldown header#3101
Merged
djanickova merged 1 commit intoMay 12, 2026
Merged
Conversation
Signed-off-by: Diana Janickova <djanicko@redhat.com>
Changed Packages
|
|
djanickova
requested review from
a team,
Eswaraiahsapram,
christoph-jerolimov and
its-mitesh-kumar
as code owners
djanickova
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
=======================================
Coverage 57.28% 57.28%
=======================================
Files 2070 2070
Lines 63740 63740
Branches 16742 16743 +1
=======================================
Hits 36513 36513
Misses 26684 26684
Partials 543 543
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Eswaraiahsapram
approved these changes
May 11, 2026
Member
Eswaraiahsapram
left a comment
Eswaraiahsapram
left a comment
There was a problem hiding this comment.
Thanks @djanickova , looks good to me 🎉
lokanandaprabhu
pushed a commit
to lokanandaprabhu/rhdh-plugins
that referenced
this pull request
May 14, 2026
…r#3101) Signed-off-by: Diana Janickova <djanicko@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
RHDHBUGS-3119
The drilldown page header was looking up
metric.filecheck.codeowners.titledirectly, which doesn't exist. It fell back to the raw provider title ("File: CODEOWNERS"), which differed from the homepage card title ("File check: codeowners").The homepage card already used
resolveMetricTranslation, which has a template fallback (metric.filecheck.title + name) that produces the correct label. Applying the same function to the drilldown page makes the two titles consistent.I discovered this during the process of writing new e2e tests for scorecard, so checking the correct title will be covered in these tests.
✔️ Checklist