New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET Core 2.0 imagestream. #99

Merged
merged 1 commit into from Aug 22, 2017

Conversation

Projects
None yet
5 participants
@jerboaa
Contributor

jerboaa commented Aug 8, 2017

The images are not in the RH registry yet, so there is no point in merging it currently. Any thoughts or objections?

@jerboaa jerboaa requested review from aslicerh and omajid Aug 8, 2017

@omajid

omajid approved these changes Aug 8, 2017

@@ -29,11 +29,29 @@
"supports":"dotnet",
"sampleRepo": "https://github.com/redhat-developer/s2i-dotnetcore-ex.git",
"sampleContextDir": "app",
"sampleRef": "dotnetcore-1.1"
"sampleRef": "dotnetcore-2.0"

This comment has been minimized.

@aslicerh

aslicerh Aug 8, 2017

Member

Should these still say 'dotnetcore'?

@aslicerh

aslicerh Aug 8, 2017

Member

Should these still say 'dotnetcore'?

This comment has been minimized.

@jerboaa

jerboaa Aug 8, 2017

Contributor

Those are the branch names within https://github.com/redhat-developer/s2i-dotnetcore-ex.git. I've kept them consistent with older existing ones like dotnetcore-1.1. What do you suggest? Change the branch name and rename it here? I don't think it's worth doing from a cost/benefit perspective.

@jerboaa

jerboaa Aug 8, 2017

Contributor

Those are the branch names within https://github.com/redhat-developer/s2i-dotnetcore-ex.git. I've kept them consistent with older existing ones like dotnetcore-1.1. What do you suggest? Change the branch name and rename it here? I don't think it's worth doing from a cost/benefit perspective.

This comment has been minimized.

@aslicerh

aslicerh Aug 8, 2017

Member

Ah, I see. I don't (necessarily) have a problem with leaving it as is, I just brought it up because of the change in naming conventions that we've been doing. Though I can also see that just because the RPM/product has to be named X doesn't mean that the internal repos need to be.

@aslicerh

aslicerh Aug 8, 2017

Member

Ah, I see. I don't (necessarily) have a problem with leaving it as is, I just brought it up because of the change in naming conventions that we've been doing. Though I can also see that just because the RPM/product has to be named X doesn't mean that the internal repos need to be.

Add .NET Core 2.0 imagestreams.
Now there are two imagestreams, dotnet and
dotnet-runtime. The former are for all builder
images, the later for runtime images.
@jerboaa

This comment has been minimized.

Show comment
Hide comment
@jerboaa

jerboaa Aug 10, 2017

Contributor

@tmds @aslicerh I've added the runtime imagestream. You can refer to it via dotnet-runtime:2.0. Please let me know what you think.

Contributor

jerboaa commented Aug 10, 2017

@tmds @aslicerh I've added the runtime imagestream. You can refer to it via dotnet-runtime:2.0. Please let me know what you think.

@tmds

This comment has been minimized.

Show comment
Hide comment
@tmds

tmds Aug 10, 2017

Member

👍

Member

tmds commented Aug 10, 2017

👍

@aslicerh

This comment has been minimized.

Show comment
Hide comment
@aslicerh

aslicerh Aug 10, 2017

Member

Looks good to me.

Member

aslicerh commented Aug 10, 2017

Looks good to me.

@sdodson

This comment has been minimized.

Show comment
Hide comment
@sdodson

sdodson Aug 22, 2017

Is there anything blocking the merge of this PR?

sdodson commented Aug 22, 2017

Is there anything blocking the merge of this PR?

@omajid

This comment has been minimized.

Show comment
Hide comment
@omajid

omajid Aug 22, 2017

Member

We were waiting for the release to go out. I guess we can merge this now?

Member

omajid commented Aug 22, 2017

We were waiting for the release to go out. I guess we can merge this now?

@aslicerh

This comment has been minimized.

Show comment
Hide comment
@aslicerh

aslicerh Aug 22, 2017

Member

@omajid @sdodson
We're also waiting on one more test process as well, that couldn't be completed until the official container images were pushed, which didn't happen until this morning.

Member

aslicerh commented Aug 22, 2017

@omajid @sdodson
We're also waiting on one more test process as well, that couldn't be completed until the official container images were pushed, which didn't happen until this morning.

@jerboaa jerboaa changed the title from [Do not merge] Add .NET Core 2.0 imagestream. to Add .NET Core 2.0 imagestream. Aug 22, 2017

@jerboaa jerboaa merged commit 5404ec6 into redhat-developer:master Aug 22, 2017

1 check passed

RH build bot Everything builds fine.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment