Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add switch context to tree view title #1019

Merged
merged 4 commits into from Aug 12, 2019

Conversation

mohitsuman
Copy link
Collaborator

fix #996

package.json Outdated Show resolved Hide resolved
src/openshift/cluster.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #1019 into master will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   85.88%   85.83%   -0.06%     
==========================================
  Files          30       30              
  Lines        1969     1969              
  Branches      342      342              
==========================================
- Hits         1691     1690       -1     
- Misses        278      279       +1
Impacted Files Coverage Δ
src/odo.ts 84.56% <0%> (ø) ⬆️
src/openshift/cluster.ts 89.78% <0%> (ø) ⬆️
src/util/watch.ts 96.55% <0%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af5958...b3c956f. Read the comment docs.

Copy link
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should investigate why it always happening for me after switching context

oc v3.11.0+0cbc58b
kubernetes v1.11.0+d4cacc0
features: Basic-Auth SSPI Kerberos SPNEGO
error: server took too long to respond with version information.

@mohitsuman
Copy link
Collaborator Author

error: server took too long to respond with version information.

Can you help in how you reproduced this issue, I can then have a look.
Is this happening from context switch 3.x to 4.x or vice versa ?

@mohitsuman
Copy link
Collaborator Author

@dgolovin I have added a working scenario with the attached gif. This allows me to perform the context switching between different clusters.
Here I am doing a switch between local 3.x and local 4.x cluster. The actions works seamlessly. Can you please check and let me know.

switch-ctxt

@mohitsuman mohitsuman merged commit 5e36284 into redhat-developer:master Aug 12, 2019
@mohitsuman mohitsuman deleted the gh-996 branch June 16, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add action to switchContexts for the entire tree
2 participants