From 591bf7a024d404676bf3a44a73eb67614d479283 Mon Sep 17 00:00:00 2001 From: Nikolas Komonen <32624665+NikolasKomonen@users.noreply.github.com> Date: Tue, 4 Jun 2019 15:31:12 -0400 Subject: [PATCH 1/3] Added maven info --- CONTRIBUTING.md | 24 ++++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3b26f852..0f07383c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,6 +9,7 @@ Contributions are essential for keeping this extension great. We try to keep it * latest [Visual Studio Code](https://code.visualstudio.com/) * [Node.js](https://nodejs.org/) v4.0.0 or higher * [JDK 8+](http://www.oracle.com/technetwork/java/javase/downloads/index.html) + * [Maven](https://maven.apache.org/) ### Steps 1. Fork and clone this repository @@ -24,21 +25,28 @@ Contributions are essential for keeping this extension great. We try to keep it ├──── vscode-xml/ ``` -3. `cd vscode-xml/` - -4. Install the dependencies: +3. `cd lsp4xml/` + +4. Install the maven dependencies: + ```bash + $ mvn install + ``` + - ```bash +5. `cd vscode-xml/` + +6. Install the dependencies: + ```bash $ npm install ``` -5. In `vscode-xml/`, build the server by running: +7. In `vscode-xml/`, build the server by running: - ```bash + ```bash $ npm run build-server ``` -6. To run the extension, open the Debugging tab in VSCode. -7. Select and run 'Launch Extension (vscode-xml)' at the top left: +8. To run the extension, open the Debugging tab in VSCode. +9. Select and run 'Launch Extension (vscode-xml)' at the top left: ![ Launch Extension ](./images/LaunchExtension.png) From 28021c0bae31a6270fa2856b8648c1afa5beddb0 Mon Sep 17 00:00:00 2001 From: Nikolas Komonen <32624665+NikolasKomonen@users.noreply.github.com> Date: Wed, 21 Aug 2019 09:23:24 -0400 Subject: [PATCH 2/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0f07383c..ac33f82a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -29,7 +29,11 @@ Contributions are essential for keeping this extension great. We try to keep it 4. Install the maven dependencies: ```bash - $ mvn install + $ ./mvnw verify + ``` + or + ```bash + $ mvnw.cmd verify ``` From d765c9de0e0adecacbbbaef31aa095ea9dd0d8df Mon Sep 17 00:00:00 2001 From: Nikolas Komonen <32624665+NikolasKomonen@users.noreply.github.com> Date: Wed, 21 Aug 2019 09:54:17 -0400 Subject: [PATCH 3/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ac33f82a..cb2ffd93 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -27,12 +27,12 @@ Contributions are essential for keeping this extension great. We try to keep it 3. `cd lsp4xml/` -4. Install the maven dependencies: - ```bash +4. Install the maven dependencies Mac/Linux: + ```bash $ ./mvnw verify ``` - or - ```bash + or for Windows: + ```bash $ mvnw.cmd verify ```