-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded promise constructors #351
Conversation
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@@ -5,7 +5,7 @@ | |||
*--------------------------------------------------------------------------------------------*/ | |||
'use strict'; | |||
|
|||
import { PromiseConstructor, Thenable } from 'vscode-json-languageservice'; | |||
import { Thenable } from 'vscode-json-languageservice'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need Thenable
either.
@@ -10,7 +10,7 @@ import { ASTNode, ObjectASTNode, PropertyASTNode } from '../jsonASTTypes'; | |||
import { parse as parseYAML } from '../parser/yamlParser07'; | |||
import { YAMLSchemaService } from './yamlSchemaService'; | |||
import { JSONSchema, JSONSchemaRef } from '../jsonSchema'; | |||
import { PromiseConstructor, Thenable, JSONWorkerContribution, CompletionsCollector } from 'vscode-json-languageservice'; | |||
import { Thenable, CompletionsCollector } from 'vscode-json-languageservice'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need Thenable
here either.
I guess I can stop reviewing this. :-) |
I'm going to make another PR that switches all Thenable to Promise 😄 |
You promise? |
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What does this PR do?
This PR removes promise constructors since they aren't actually used anywhere. We've always just used Promise and never passed anything different in
What issues does this PR fix or reference?
Is it tested? How?
npm run test