Explicitly require rabbitmq service before setting HA policy #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olicy https://bugzilla.redhat.com/show_bug.cgi?id=1147077 This is yet another case of class containment gone wrong. The mirrored queues exec requires ::rabbitmq, and the latter includes ::rabbitmq::service which declares the service. Since ::rabbitmq does not 'contain' ::rabbitmq:service, the dependency does not get applied to the mirrored queues exec. Thus, it is possible for the exec to run before the service is started.
jeckersb
force-pushed
the
require-rabbitmq-service
branch
from
d4d2e04
to
10dfa13
Compare
jguiditta
added a commit
that referenced
this pull request
Sep 26, 2014
Explicitly require rabbitmq service before setting HA policy
jeckersb
added a commit
to jeckersb/astapor
that referenced
this pull request
Sep 26, 2014
…olicy https://bugzilla.redhat.com/show_bug.cgi?id=1147077 PR erratum for redhat-openstack#372. Require the class instead of the service resource, since the service resource does not exist after the first run due to the service being unmanaged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another case of class containment gone wrong. The
mirrored queues exec requires ::rabbitmq, and the latter includes
::rabbitmq::service which declares the service. Since ::rabbitmq does
not 'contain' ::rabbitmq:service, the dependency does not get applied
to the mirrored queues exec. Thus, it is possible for the exec to run
before the service is started.