Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fixes Facts string comparisons in CentOS 7
CentOS Project has adopted a new rule for versioning numbers. The major number
matches the RHEL major number, but the minor number is generated from the
release date. For example, CentOS 7.1407.

Change-Id: I16876d033bdb8ee47fa7b3c2d25c41e6f1c1c83e
Fixes: rhbz#1117035
Signed-off-by: Gael Chamoulaud <gchamoul@redhat.com>
  • Loading branch information
strider committed Jul 8, 2014
1 parent 204f39e commit 0040c63
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packstack/puppet/templates/amqp.pp
Expand Up @@ -44,7 +44,7 @@
}

'RedHat', 'CentOS': {
if $::operatingsystemrelease >= 7 {
if $::operatingsystemmajrelease >= 7 {
$config = '/etc/qpid/qpidd.conf'
} else {
$config = '/etc/qpidd.conf'
Expand Down
2 changes: 1 addition & 1 deletion packstack/puppet/templates/mysql_install.pp
@@ -1,6 +1,6 @@

# on EL6 we need to wait for innodb changes before starting mysqld
if $::operatingsystem in ['RedHat','CentOS','Scientific'] and $::operatingsystemrelease < 7 {
if $::operatingsystem in ['RedHat','CentOS','Scientific'] and $::operatingsystemmajrelease < 7 {
$manage_service = false
service { 'mysqld':
enable => true,
Expand Down
2 changes: 1 addition & 1 deletion packstack/puppet/templates/prescript.pp
Expand Up @@ -10,7 +10,7 @@
}

# For older RHEL-6 releases kernel/iptools does not support netns
if $::operatingsystem in $el_releases and $::operatingsystemrelease < 7 {
if $::operatingsystem in $el_releases and $::operatingsystemmajrelease < 7 {
$info = "The RDO kernel that includes network namespace (netns) support has been installed on host $::ipaddress."
$warning = " This is a community supplied kernel and is not officially supported by Red Hat. Installing this kernel on RHEL systems may impact your ability to get support from Red Hat."

Expand Down

1 comment on commit 0040c63

@kk47
Copy link

@kk47 kk47 commented on 0040c63 Aug 9, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ,strider :
I got some error when i install opstack allinon mode on centos 7 use packstack . And i just cover the 3 file of your commit in /usr/lib/python2.7/site-packages/packstack/puppet/templates/ . Hope you can help find where is the problem exact locate.
Command is like this:
packstack --allinone // packstack --answer-file=/root/packstack-answers-20140809-050728.txt
Preparing servers [ DONE ]
Adding AMQP manifest entries [ ERROR ]
ERROR : float argument required, not dict
Please check log file /var/tmp/packstack/20140809-060353-hPzqeJ/openstack-setup.log for more information

and the log in tmp show me that:
rpm -q epel-release && yum-config-manager --setopt="rhel-server-ost-6-4-rpms.priority=1" --save rhel-server-ost-6-4-rpms
yum clean metadata
2014-08-09 06:04:30::ERROR::run_setup::920::root:: Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/packstack/installer/run_setup.py", line 915, in main
_main(confFile)
File "/usr/lib/python2.7/site-packages/packstack/installer/run_setup.py", line 605, in _main
runSequences()
File "/usr/lib/python2.7/site-packages/packstack/installer/run_setup.py", line 584, in runSequences
controller.runAllSequences()
File "/usr/lib/python2.7/site-packages/packstack/installer/setup_controller.py", line 68, in runAllSequences
sequence.run(config=self.CONF, messages=self.MESSAGES)
File "/usr/lib/python2.7/site-packages/packstack/installer/core/sequences.py", line 98, in run
step.run(config=config, messages=messages)
File "/usr/lib/python2.7/site-packages/packstack/installer/core/sequences.py", line 44, in run
raise SequenceError(str(ex))
SequenceError: float argument required, not dict

Please sign in to comment.