Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servername in Markdown tables wrap when they shouldn't. #216

Closed
sadsfae opened this Issue Mar 13, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@sadsfae
Copy link
Member

sadsfae commented Mar 13, 2019

There's a front-end issue with Webkit-based browsers like Chrome, Brave, Safari in that they ignore the CSS word-break directive, but browsers using Gecko honor this.

e.g.

.site-content {
       word-wrap: normal;
       word-break: keep-all;
}

Still makes longer hostnames wrap.

@sadsfae sadsfae added this to the 1.1.0 milestone Mar 13, 2019

sadsfae added a commit that referenced this issue Mar 13, 2019

Webkit ignores word-break CSS, extend wiki table.
Browsers that use Webkit like Google Chrome, Safari, do not properly
honor the word-break CSS attribute that we use to ensure long hostnames
are not wrapped. e.g.

.site-content {
       word-wrap: normal;
       word-break: keep-all;
}

A pragmatic fix to this is ensure our Markdown table column titles are
at least as long as our longest, unbroken string of text.

e.g. replacing ServerHostname with ServerHostnamePublic seems to do the
trick.

fixes: #216

Change-Id: I9a20902dd8801b1b91847d0b019f2f807eef2553
@sadsfae

This comment has been minimized.

Copy link
Member Author

sadsfae commented Mar 13, 2019

This is resolved.

@sadsfae sadsfae closed this Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.