Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need a grace period for validate_env.py #241

Closed
sadsfae opened this issue May 10, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@sadsfae
Copy link
Member

commented May 10, 2019

We don't seem to have a grace period for when quads/tools/validate_env.py runs to tell us if there are any validation check failures.

For example I just scheduled an assignment to start on 2019-05-10 10:00 but I've already received a validation check email notification only 10 minutes later.

Note I adjusting for UTC vs BST/IST timezone differences that's only 10 minutes later.

date:	May 10, 2019, 11:10 AM
subject:    Validation check failed for cloud05 / wfoster / 654321

I I propose we provide a configurable validation_grace_period in conf/quads.yml with a default of 120 minutes so that no validation failure emails would be spuriously sent in a reasonable time frame.

@sadsfae sadsfae added this to the 1.1.0 milestone May 10, 2019

@sadsfae sadsfae changed the title We need grace period for validate_env.py We need a grace period for validate_env.py May 10, 2019

@sadsfae sadsfae added bug and removed enhancement labels May 10, 2019

@grafuls

This comment has been minimized.

sadsfae pushed a commit that referenced this issue May 15, 2019

Added grace period for validate_env
For this solution we can rely on the timestamp we use under the
host document for last_build. We are now checking that the host has
120 minutes to reprovision before we start with the validation.
This comes in the form of an additional parameter under quads.yml
configuration file.

Fixes: #241

Change-Id: I533d2cb78f51baadfdc477fa1e56cf59f749232c

@sadsfae sadsfae closed this May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.