Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Wipe setting needs to reset on --define --force #251

Closed
sadsfae opened this issue May 23, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@sadsfae
Copy link
Member

commented May 23, 2019

It appears that the wipe: 0/1 setting of quads-cli --define-cloud does not reset when an environment is redefined for future use.

The expected behavior here is that this value is reset back to the default.

Most people will want to wipe before proceeding with deploying new infrastructure.

@sadsfae sadsfae added this to the 1.1.0 milestone May 23, 2019

@grafuls

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

If we are having a default of wipe=True then why not refactor this to a cli boolean flag for --no-wipe.
When passed wipe=False when not passed wipe=True.
(?)

@grafuls

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

sadsfae pushed a commit that referenced this issue May 27, 2019

Moved wipe argument to an optional boolean flag.
Modified --wipe [value] for --no-wipe optional flag.
Wipe is True by default when no flag is passed. If the flag --no-wipe
is used on cloud definition, then wipe will be set as False.

Fixes: #251
Change-Id: I1523e844d0b26acc00b0a2fe56e2cfe3f6dd595d

@sadsfae sadsfae closed this May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.