Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libforeman.py doesn't seem to enforce OS, medium, ptable #279

Closed
sadsfae opened this issue Aug 6, 2019 · 2 comments

Comments

@sadsfae
Copy link
Member

commented Aug 6, 2019

Related to: #186

It seems that we are still not enforcing OS, medium and ptable in https://github.com/redhat-performance/quads/blob/master/quads/tools/move_and_rebuild_hosts.py#L170

@sadsfae

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

I wonder if we shouldn't be calling the OS id instead of by the friendly name, e.g.

[root@foreman ~]# hammer os list
---|-----------------------|--------------|-------
ID | TITLE                 | RELEASE NAME | FAMILY
---|-----------------------|--------------|-------
4  | CentOS 7              |              | Redhat
1  | CentOS Linux 7.5.1804 |              | Redhat
3  | DummyOS               |              | Redhat
5  | Fedora 29             |              | Redhat
8  | Fedora 30             |              | Redhat
2  | RHEL 7                |              | Redhat
7  | RHEL 8                |              | Redhat
---|-----------------------|--------------|-------

@sadsfae sadsfae added this to the 1.1.0 milestone Aug 8, 2019

@sadsfae

This comment has been minimized.

Copy link
Member Author

commented Aug 8, 2019

Issue here is we need to call all the ptable, os, medium, arch settings in the same API post request.

ipdb> response.text
'{\n  "error": {"id":684,"errors":{"medium_id":["Fedora Local does not belong to RedHat 7.6 operating system"]}

sadsfae pushed a commit that referenced this issue Aug 9, 2019

Fix for foreman remove_ext_interfaces.
When trying to remove extraneous interfaces from foreman we were
not passing credentials.
Also removed a few foreman parameters settings since no longer
necessary for 1.1.

Fixes: #279
Change-Id: I1a3827f4106eb40c92f4734cef8b83d2cefcd452

@grafuls grafuls closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.