Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Add badfish credentials check to validate_env #280

Closed
grafuls opened this issue Aug 29, 2019 · 1 comment
Assignees
Projects
Milestone

Comments

@grafuls
Copy link
Contributor

@grafuls grafuls commented Aug 29, 2019

Is your feature request related to a problem? Please describe.
We do not check for ipmi credentials during validation.

Describe the solution you'd like
After an environment is released and once we enter the validation stage, we could ask badfish to verify impi credentials and report a failure if credentials are not correct.

Describe alternatives you've considered
Use badfish to verify ipmi credentials as with get_system_service.

@grafuls grafuls added this to the 1.2.0 milestone Aug 29, 2019
@grafuls grafuls added this to To do in 1.2 via automation Aug 29, 2019
@grafuls

This comment has been minimized.

Copy link
Contributor Author

@grafuls grafuls commented Oct 9, 2019

@grafuls grafuls self-assigned this Oct 9, 2019
@grafuls grafuls moved this from To do to In progress in 1.2 Oct 9, 2019
sadsfae pushed a commit that referenced this issue Oct 9, 2019
Added validate_credentials method to badfish library and calling
this as an additional step on validate_env

fixes:
#145
#280

Change-Id: I098256a0b5a8bb2cb2e12ebcdb0db5fdd62b0e11
@grafuls grafuls closed this Oct 9, 2019
@grafuls grafuls moved this from In progress to Done in 1.2 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.2
  
Done
1 participant
You can’t perform that action at this time.