Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more hosts to an existing cloud in the future triggers re-validation #304

Closed
sadsfae opened this issue Dec 19, 2019 · 1 comment
Closed

Comments

@sadsfae
Copy link
Member

@sadsfae sadsfae commented Dec 19, 2019

  • QUADS version quads-1.1.2-20191216.noarch (same as quads-dev or master branch)
  • Python version: Python 3.7.4
  • Operating System: Fedora 29

Describe the bug
Adding additional hosts to an existing assignment that will join well into the future seems to toggle the cloud validation back to validating on the wiki.

What seems to be happening is there isn't a check that if hosts are added to join later (beyond current datetime = now) somehow the validate flag gets toggled at the cloud level.

Screenshot_2019-12-19_18-38-28

The example above, 300 x systems were scheduled to be added to cloud12 on 2020-01-05 22:00 however right now, prior to that, the cloud reverted to Validating

I have not looked into the code base deeper but there's been some recent feature commits that address validations to systems added to already existing environments and may be related:

cc5737d

@sadsfae sadsfae added this to the 1.2 Series milestone Dec 19, 2019
@sadsfae sadsfae added this to To do in 1.1 and 1.2 Series via automation Dec 19, 2019
@sadsfae sadsfae moved this from To do to To Do: High Priority & Bugs in 1.1 and 1.2 Series Dec 19, 2019
@kambiz-aghaiepour

This comment has been minimized.

Copy link
Contributor

@kambiz-aghaiepour kambiz-aghaiepour commented Dec 19, 2019

Looking at:

https://review.gerrithub.io/c/redhat-performance/quads/+/477967/2/quads/api_v2.py

we actually don't really consider the start time when we mark the cloud as validation=False. We would have to have a way of knowing that a future schedule is about to kick in (which means a process loop that constantly looks at the "about to kick in" schedules) and only toggle the cloud level Validation attribute to False at a designated time. I'm not sure if this is worthwhile. This is worthy of discussion.

Perhaps the code that toggles to false the notification=true and validation=true settings needs to move into the M&R functionality?

@grafuls grafuls moved this from To Do: High Priority & Bugs to In progress in 1.1 and 1.2 Series Dec 20, 2019
@sadsfae sadsfae closed this in 2944c1b Dec 20, 2019
1.1 and 1.2 Series automation moved this from In progress to Done Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.