profiles: fix loading multiple profiles if there are repeating profiles #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure whether this simplified profile loading mechanism could bring some unexpected behavior e.g. in combination with the 'replace=true', but it's definitely improvement over what we had. |
The original idea behind this patch is credited to Jiří Mencák <jmencak@redhat.com>. Resolves: rhbz#1825882 Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
yarda
force-pushed
the
multiple-profiles-loading
branch
from
e06e0ac
to
bd6697f
Compare
CZerta
approved these changes
Jun 9, 2021
|
Thank you Jaroslav for an improved fix and Honzo for the review! I did some extra testing and I'm unable to find/think of any side effects at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea behind this patch is credited to
Jiří Mencák jmencak@redhat.com.
Resolves: rhbz#1825882
Signed-off-by: Jaroslav Škarvada jskarvad@redhat.com