builtin functions: added calc_isolated_cores function #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarda
force-pushed
the
builtin_function_calc_isolated_cores
branch
from
2b70303
to
6570f91
Compare
|
EPEL-7 failure is probably caused by some changes on the testing farm. |
yarda
force-pushed
the
builtin_function_calc_isolated_cores
branch
2 times, most recently
from
6a32621
to
cbcc000
Compare
|
/packit build |
CZerta
requested changes
Aug 9, 2022
| return None | ||
| cpus_reserve = 1 | ||
| if len(args) > 0: | ||
| if not args[0].isdecimal() or int(args[0]) < 0: |
There was a problem hiding this comment.
Shouldn't there be int(args[0]) <= 0 to always have at least one housekeeping core? If there can be no isolated core the error log on next line probably should say ... non-negative integer
There was a problem hiding this comment.
0 is valid setting - to have no housekeeping core. I will update the error message.
The calc_isolated_cores function expands to the list of cores to
isolate. It accepts optional argument which specifies how many cores
from each socket reserve for housekeeping. If not specified, one core
from each socket is reserved for housekeeping.
Example:
Machine with 2 sockets, each 4 cores, using the following user variable
configuration file, e.g. /etc/tuned/realtime-variables.conf:
isolated_cores=${f:calc_isolated_cores:2}
It will expand to:
isolated_cores=2, 3, 6, 7
I.e. cores 0, 1 and 4, 5 will be used for housekeeping.
Also updated the TuneD profiles to use this builtin function for
isolated_cores preset.
Resolves: rhbz#2093847
Signed-off-by: Jaroslav Škarvada <jskarvad@redhat.com>
yarda
force-pushed
the
builtin_function_calc_isolated_cores
branch
from
cbcc000
to
39e6d14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calc_isolated_cores function expands to the list of cores to
isolate. It accepts optional argument which specifies how many cores
from each socket reserve for housekeeping. If not specified, one core
from each socket is reserved for housekeeping.
Example:
Machine with 2 sockets, each 4 cores, using the following user variable
configuration file, e.g. /etc/tuned/realtime-variables.conf:
isolated_cores=${f:calc_isolated_cores:2}
It will expand to:
isolated_cores=2, 3, 6, 7
I.e. cores 0, 1 and 4, 5 will be used for housekeeping.
Resolves: rhbz#2093847
Signed-off-by: Jaroslav Škarvada jskarvad@redhat.com