Skip to content

Allow specifying WORK_DIR for intermediate files - #393

Merged
mergify[bot] merged 1 commit into
redhat-plumbers-in-action:mainfrom
mpoberezhniy:allow-specifying-work-dir-for-intermediate-files
Apr 29, 2024
Merged

Allow specifying WORK_DIR for intermediate files#393
mergify[bot] merged 1 commit into
redhat-plumbers-in-action:mainfrom
mpoberezhniy:allow-specifying-work-dir-for-intermediate-files

Conversation

@mpoberezhniy

Copy link
Copy Markdown
Contributor

This is required for #234.

Since pre-commit passes --user=<UID:GID> and --workdir=/src - files can not be created at /.

Ran the tests:

...
summary_useful_links.bats
 ✓ summary_useful_links()

87 tests, 0 failures

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.96%. Comparing base (52bab0c) to head (2a59007).

Files Patch % Lines
src/index.sh 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   84.80%   84.96%   +0.15%     
==========================================
  Files           4        4              
  Lines         283      286       +3     
==========================================
+ Hits          240      243       +3     
  Misses         43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamacku jamacku added the type: feature New feature label Apr 29, 2024

@jamacku jamacku left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@mergify
mergify Bot merged commit 8f0e0a6 into redhat-plumbers-in-action:main Apr 29, 2024
@mpoberezhniy
mpoberezhniy deleted the allow-specifying-work-dir-for-intermediate-files branch April 29, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants