fix: check if base sha exists - #482
Merged
Merged
Conversation
When base branch is out of date (not synced with upstream), the base sha could have value of `0000000000000000000000000000000000000000`. In such case differential ShellCheck can't use it to compare with the head sha and it will exit.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
==========================================
- Coverage 73.33% 72.97% -0.37%
==========================================
Files 5 5
Lines 330 333 +3
==========================================
+ Hits 242 243 +1
- Misses 88 90 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When base branch is out of date (not synced with upstream), the base sha could have value of
0000000000000000000000000000000000000000. In such case differential ShellCheck can't use it to compare with the head sha and it will exit.This should make cases like this easier to debug: