Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#2050556) fix(dracut-shutdown): add cleanup handler on failure #23

Merged
merged 1 commit into from Feb 16, 2022

Conversation

systemd-rhel-bot
Copy link
Contributor

No description provided.

@lnykryn
Copy link
Contributor

lnykryn commented Feb 9, 2022

error: Installed (but unpackaged) file(s) found:
/usr/lib/systemd/system/dracut-shutdown-onfailure.service
Installed (but unpackaged) file(s) found:
/usr/lib/systemd/system/dracut-shutdown-onfailure.service

also needs a specfile change

It may happen that dracut-shutdown.service fails, for example on timeout
due to very low bandwidth.
In such case, for hardening purposes, a new dracut-shutdown-onfailure.service
unit doing dracut-shutdown.service cleanup needs to execute to make sure
switching root to an incomplete initramfs won't occur later.

See also RHBZ #1924587 (https://bugzilla.redhat.com/show_bug.cgi?id=1924587).

(cherry picked from commit 7ab1d00)

Resolves: #2050556
@pvalena
Copy link
Contributor

pvalena commented Feb 15, 2022

LGTM.

@pvalena
Copy link
Contributor

pvalena commented Feb 16, 2022

error: Installed (but unpackaged) file(s) found: /usr/lib/systemd/system/dracut-shutdown-onfailure.service Installed (but unpackaged) file(s) found: /usr/lib/systemd/system/dracut-shutdown-onfailure.service

also needs a specfile change

Done with the import. Tested. (https://brew*****.redhat.com/brew/taskinfo?taskID=43089326)

@pvalena pvalena merged commit 865d74e into redhat-plumbers:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants