Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(url-lib): write curl output directly to file #51

Merged
merged 1 commit into from Nov 25, 2022

Conversation

lnykryn
Copy link
Contributor

@lnykryn lnykryn commented Sep 20, 2022

The redirection to stdout was originally added to workaround https://bugzilla.redhat.com/show_bug.cgi?id=989133 (curl would create no file if the source was empty), but I don't see that problem with current curl.

A nice side-effect of this change is that curl shows download progress.

(cherry picked from commit 1343d21d8c0d1f7239e27165e9c7633b504f777f)

Resolves: #2112475

(cherry picked from commit ... )

Resolves: #

The redirection to stdout was originally added to workaround
https://bugzilla.redhat.com/show_bug.cgi?id=989133 (curl would create no
file if the source was empty), but I don't see that problem with current
curl.

A nice side-effect of this change is that curl shows download progress.

(cherry picked from commit 1343d21d8c0d1f7239e27165e9c7633b504f777f)

Resolves: #2112475
@pvalena
Copy link
Contributor

pvalena commented Nov 25, 2022

LGTM.

@pvalena
Copy link
Contributor

pvalena commented Nov 25, 2022

FYI @jamacku:

Error: It wasn't possible to enable this project.
Repository 'epel-9-x86_64' does not exist in project 'packit/redhat-plumbers-dracut-rhel9-51'.
Available repositories: 'centos-stream-9-x86_64', 'centos-stream-9-aarch64'

If you want to enable a non-default repository, use the following command:
  'dnf copr enable packit/redhat-plumbers-dracut-rhel9-51 <repository>'
But note that the installed repo file will likely need a manual modification.

@pvalena pvalena merged commit f93ac80 into redhat-plumbers:main Nov 25, 2022
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants