Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1828758) install: refactor find_symlinks() and don't search for symlinks recur… #135

Merged

Conversation

dtardon
Copy link
Member

@dtardon dtardon commented Nov 19, 2021

…sively

After all we are only interested in symlinks either in top-level config
directory or in .wants and .requires sub-directories.

As a bonus this should speed up ListUnitFiles() roughly 3-4x on systems
with a lot of units that use drop-ins (e.g. SSH jump hosts with a lot of
user session scopes).

(cherry picked from commit 43b4e30)

Resolves: #1828758

…sively

After all we are only interested in symlinks either in top-level config
directory or in .wants and .requires sub-directories.

As a bonus this should speed up ListUnitFiles() roughly 3-4x on systems
with a lot of units that use drop-ins (e.g. SSH jump hosts with a lot of
user session scopes).

(cherry picked from commit 43b4e30)

Resolves: #1828758
@systemd-rhel-bot systemd-rhel-bot added pr/needs-ci Formerly needs-ci pr/needs-review Formerly needs-review labels Nov 19, 2021
@systemd-rhel-bot systemd-rhel-bot changed the title install: refactor find_symlinks() and don't search for symlinks recur… (#1828758) install: refactor find_symlinks() and don't search for symlinks recur… Nov 19, 2021
@systemd-rhel-bot systemd-rhel-bot added needs-itr and removed pr/needs-ci Formerly needs-ci needs-itr labels Nov 19, 2021
Copy link
Member

@msekletar msekletar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systemd-rhel-bot systemd-rhel-bot removed the pr/needs-review Formerly needs-review label Nov 25, 2021
@systemd-rhel-bot systemd-rhel-bot merged commit b864dc9 into redhat-plumbers:master Nov 25, 2021
@dtardon dtardon deleted the bz1828758-list-unit-files branch November 26, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants