(#2151612) Restore pre-252 behavior of HibernateDelaySec= #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3d23df0) Related: #2151612
(cherry picked from commit d812e10) Related: #2151612
(cherry picked from commit 2ed56af) Related: #2151612
Before v252, HibernateDelaySec= specifies the maximum timespan that the system in suspend state, and the system hibernate after the timespan. However, after 96d662f, the setting is repurposed as the default interval to measure battery charge level and estimate the battery discharging late. And if the system has enough battery capacity, then the system will stay in suspend state and not hibernate even if the time passed. See issue #25269. To keep the backward compatibility, let's introduce another setting SuspendEstimationSec= for controlling the interval to measure battery charge level, and make HibernateDelaySec= work as of v251. This also drops implementation details from the man page. Fixes #25269. (cherry picked from commit 4f58b65) Resolves: #2151612
(cherry picked from commit 3c3f460) Related: #2151612
- use device_get_sysattr_int(), - drop redundant log message. (cherry picked from commit 3d9ca76) Related: #2151612
(cherry picked from commit 3332cfe) Related: #2151612
The enumerator is now mostly consistent with on_ac_power() in udev-util.c. (cherry picked from commit fe8e0f8) Related: #2151612
systemd-rhel-bot
changed the title
systemd-rhel-bot
added
tracker/missing
systemd-rhel-bot
removed
pr/needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2151612