New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to SOAP::Lite repo in comment #13

Merged
merged 1 commit into from Aug 14, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Jul 10, 2018

I noticed that the link to the SOAP::Lite SVN repo no longer exists and updated it to point to the current repo location.

While reading the comments surrounding this code I'm wondering if this particular line might be a leftover from the fork from SOAP::Lite. It looks (to me) like the comment about tracking modifications could actually mean one should point to the XML::Parser::Lite repo and not SOAP::Lite. Anyway, let me know which this should be and I'll update the PR appropriately and resubmit if necessary.

@redhotpenguin

This comment has been minimized.

Show comment
Hide comment
@redhotpenguin

redhotpenguin Aug 9, 2018

Owner

This should point to perl-XMLParser-Lite. I pulled this module out of SOAP::Lite because the interactive dependency builder in SOAP::Lite made it really difficult to maintain.

Owner

redhotpenguin commented Aug 9, 2018

This should point to perl-XMLParser-Lite. I pulled this module out of SOAP::Lite because the interactive dependency builder in SOAP::Lite made it really difficult to maintain.

Fix comment pointing to source code repo
It was erroneously pointing to the project from which this dist was
derived: SOAP::Lite.
@paultcochrane

This comment has been minimized.

Show comment
Hide comment
@paultcochrane

paultcochrane Aug 9, 2018

Contributor

I've updated the patch and force-pushed the changes to this branch. It's also been merged to a recent master reduce the merge conflict potential.

Contributor

paultcochrane commented Aug 9, 2018

I've updated the patch and force-pushed the changes to this branch. It's also been merged to a recent master reduce the merge conflict potential.

@redhotpenguin redhotpenguin merged commit 444faf8 into redhotpenguin:master Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment