Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge trailing whitespace #9

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Jul 7, 2018

Trailing whitespace is seen in some projects as bad practice (e.g. the Linux kernel) and is hence explicitly forbidden; other projects see its removal as plain nit-picking. This PR is submitted in the hope that it is helpful, however if you don't see any need to remove such whitespace I'm happy if you close the PR as unmerged.

@redhotpenguin
Copy link
Owner

@redhotpenguin redhotpenguin commented Jul 7, 2018

Thanks!

@redhotpenguin redhotpenguin merged commit 79f06dc into redhotpenguin:master Jul 7, 2018
@paultcochrane paultcochrane deleted the paultcochrane:pr/purge-trailing-whitespace branch Jul 8, 2018
@paultcochrane
Copy link
Contributor Author

@paultcochrane paultcochrane commented Jul 8, 2018

Awesome! Thanks for merging those PRs so quickly! it also looks like all issues in GitHub and all tickets in RT have already been resolved in a previous release, which is also really cool :-)

@redhotpenguin
Copy link
Owner

@redhotpenguin redhotpenguin commented Jul 8, 2018

@paultcochrane
Copy link
Contributor Author

@paultcochrane paultcochrane commented Jul 8, 2018

Dunno about cutting a release just yet: I've still got a couple more PRs waiting in the wings. :-) I only mentioned the tickets because I think they merely need to be closed since they were already fixed in the last release.

@redhotpenguin
Copy link
Owner

@redhotpenguin redhotpenguin commented Jul 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.