Fix regex, tidy up npm scripts #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling c3078bd on fix-linting-error into ** on master**. |
rbrtsmith
changed the title
Ehesp
reviewed
Jul 13, 2017
package.json
Outdated
| "lint": "./node_modules/.bin/eslint ./src", | ||
| "test": "./node_modules/.bin/babel-node -- ./node_modules/.bin/babel-istanbul cover --report lcov _mocha " | ||
| "lint": "eslint ./src", | ||
| "test": "babel-node -- ./node_modules/.bin/babel-istanbul cover --report lcov _mocha " |
There was a problem hiding this comment.
Should be fine to remove ./node_modules/.bin for babel-istanbul too
There was a problem hiding this comment.
I tried that and it breaks the script. I think this is due to it not been called from an npm run command. My understanding is that here the output from babel-node (replaced with node in the other PR #7) pipes it's output to Istanbul?
There was a problem hiding this comment.
Ah yes, so it does. Once everything is sorted es6 wise we can review the tests/coverage etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% convinced that my fix to the regex actually works, but with the
/character that has been getting the eslint error: "no-useless-escape" being optional due to the?that follows it I think it can be safely removed (Tested in https://regex101.com/r/trH9Vy/1/Remove unnecessary references to
./node_modules/.bin/[package-name]. By default npm scripts will look into./node_modules/binbefore looking into global installs ref: https://firstdoit.com/no-need-for-globals-using-npm-dependencies-in-npm-scripts-3dfb478908#3d3a