Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial review #1

Closed
Keruspe opened this issue Sep 2, 2019 · 1 comment

Comments

@Keruspe
Copy link

commented Sep 2, 2019

repository

  • You don't use any exlib from rust or net so they shouldn't be i your masters
  • Why do you need PALUDIS_DO_NOTHING_SANDBOXY=1?

all packages

  • We usually don't do revisions such as -r1 for scm packages, you should just leave the version as raw "scm"
  • HOMEPAGE is already set by github.exlib
  • instead of calling autoreconf, you should use the autotools exlib

libredirectionio

  • require github with just the user param should be sufficient
  • rust is slotted, so the dependency should probably be dev-lang/rust:*

agent

  • as there is no build, dependencies should only be run dependencies
  • use keepdir
  • use insinto, doins, exeinto, doexe
@joelwurtz

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

Everything has been fixed by the last commits, thanks for your review, it's really helping us doing things right as we are discovering exherbo.

Why do you need PALUDIS_DO_NOTHING_SANDBOXY=1?

This is in our Dockerfile and it's required to make cave works, don't really know why, this is something that i have seen on some docker images for exherbo. But i removed (mainly moved in fact) our Dockerfile from this repo as it's not needed.

@joelwurtz joelwurtz closed this Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.