New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use expire_after instead of expires_in for session_store in README #64

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
2 participants
@tnantoka
Contributor

tnantoka commented Apr 4, 2017

Thank you for providing a great Gem!

expires_in is used for session_store in README#Usage. It does not seem to work.
Is'nt it mistaken with expire_after?

For Rails default CookieStore, we use expire_after.

Both CookieStore and RedisStore inherits Rack::Session::Abstract::Persisted.
It has expire_after option but not expires_in.

Thanks.

@tubbo

This comment has been minimized.

Contributor

tubbo commented Apr 4, 2017

Hey @tnantoka, thanks for your contribution! Definitely a mistake on my part when I updated the docs for Sentinel configuration, when you look at the source for Redis::Store we do accept multiple options including :expires_in, :expire_in, and :expires_after, but then looking at the source for Rack::Session::Abstract::ID that you posted, it seems that the rack session store will only accept :expires_after. I just wanted to make them all more consistent. :)

Let me know if you find any other documentation issues!

@tubbo tubbo merged commit 0e0c42f into redis-store:master Apr 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment