Use expire_after instead of expires_in for session_store in README #64
Conversation
Hey @tnantoka, thanks for your contribution! Definitely a mistake on my part when I updated the docs for Sentinel configuration, when you look at the source for Let me know if you find any other documentation issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Thank you for providing a great Gem!
expires_in
is used forsession_store
in README#Usage. It does not seem to work.Is'nt it mistaken with
expire_after
?For Rails default
CookieStore
, we useexpire_after
.Both
CookieStore
andRedisStore
inherits Rack::Session::Abstract::Persisted.It has
expire_after
option but notexpires_in
.Thanks.