Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

entitystore is not namespaced #128

Open
ababich opened this Issue · 3 comments

3 participants

@ababich

Please, take a look at redis_metastore.rb vs redis_entitystore.rb in redis-rack-cache 1.2

in Metastore you have

  class Redis < RedisBase
    # The Redis instance used to communicated with the Redis daemon.
    attr_reader :cache

    def initialize(server, options = {})
      @cache = ::Redis::Factory.create(server)
    end

while in Entitystore

  class Redis < RedisBase
    def initialize(server, options = {})
      @cache = ::Redis.new server
    end

The difference in @cache initialization makes all entitystore entries non-namespaced which generates mess in Redis at all

If there is no other reason to initialize Entitystore through plain Redis.new, please fix this to make it namespaced

@mhoran

I'll gladly merge a patch with tests. Otherwise, I'll try to get to this soon.

@ababich

Sorry, but I have no ability to push the proper patch in the closest time, will greatly appreciate if you'll be able to take a look on this

@jtblin

Hi
I fixed the issue, added the tests and sent a pull request.

Thanks!
Jerome

@ccutrer ccutrer referenced this issue from a commit in ccutrer/redis-store
@jtblin jtblin Issue 128|fixing entitystore is not namespaced (redis-store#128) and …
…adding tests for both metastore and entitystore namespaces
839ed55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.