New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified marshal code to allow efficient use of JSON when appropriate. #79

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@carlzulauf

In the spirit of pull #77 I modified the marshaling code to use JSON where appropriate (only Array/Hash for now).

This pull breaks zero specs, is compatible with existing "real world" applications, and appears to resolve all the issues brought up on gargron's pull #77.

Haven't benchmarked, but not marshaling String and looking at what the redis string starts with before unmarshaling or parsing as JSON should improve performance for some apps.

@carlzulauf

This comment has been minimized.

Show comment
Hide comment
@carlzulauf

carlzulauf Sep 6, 2011

This isn't a good patch for a number of reasons, not the least of which is it's inability to cope with arrays or hashes containing object that can't be represented in JSON.

This isn't a good patch for a number of reasons, not the least of which is it's inability to cope with arrays or hashes containing object that can't be represented in JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment