From 8236c093897b40d0d81a8cf678539e3f5eba8f34 Mon Sep 17 00:00:00 2001 From: Artem Date: Wed, 27 Sep 2023 16:17:06 +0300 Subject: [PATCH] #RI-4996 add error description for CLOUD_AUTH_FAILED events where possible --- .../api/src/modules/cloud/auth/cloud-auth.analytics.ts | 6 +++++- .../api/src/modules/cloud/auth/cloud-auth.service.ts | 8 ++++++-- ...cloud-oauth.unknown-authorization-request.exception.ts | 2 +- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/redisinsight/api/src/modules/cloud/auth/cloud-auth.analytics.ts b/redisinsight/api/src/modules/cloud/auth/cloud-auth.analytics.ts index d97c06ec2e..2faec34b16 100644 --- a/redisinsight/api/src/modules/cloud/auth/cloud-auth.analytics.ts +++ b/redisinsight/api/src/modules/cloud/auth/cloud-auth.analytics.ts @@ -15,6 +15,10 @@ export class CloudAuthAnalytics extends TelemetryBaseService { } sendCloudSignInFailed(exception: HttpException, flow?: CloudSsoFeatureStrategy, action?: string) { - this.sendFailedEvent(TelemetryEvents.CloudSignInFailed, exception, { flow, action }); + this.sendFailedEvent(TelemetryEvents.CloudSignInFailed, exception, { + flow, + action, + errorDescription: exception?.['options']?.['description'], + }); } } diff --git a/redisinsight/api/src/modules/cloud/auth/cloud-auth.service.ts b/redisinsight/api/src/modules/cloud/auth/cloud-auth.service.ts index c8efd27d02..0cd642307b 100644 --- a/redisinsight/api/src/modules/cloud/auth/cloud-auth.service.ts +++ b/redisinsight/api/src/modules/cloud/auth/cloud-auth.service.ts @@ -33,10 +33,14 @@ export class CloudAuthService { static getAuthorizationServerRedirectError(query: { error_description: string }) { if (query?.error_description?.indexOf('properties are missing') > -1) { - return new CloudOauthMissedRequiredDataException(query.error_description); + return new CloudOauthMissedRequiredDataException(query.error_description, { + description: query.error_description, + }); } - return new CloudOauthMisconfigurationException(); + return new CloudOauthMisconfigurationException(undefined, { + description: query.error_description, + }); } getAuthStrategy(strategy: CloudAuthIdpType): CloudAuthStrategy { diff --git a/redisinsight/api/src/modules/cloud/auth/exceptions/cloud-oauth.unknown-authorization-request.exception.ts b/redisinsight/api/src/modules/cloud/auth/exceptions/cloud-oauth.unknown-authorization-request.exception.ts index 6c90aeec72..a9606f3919 100644 --- a/redisinsight/api/src/modules/cloud/auth/exceptions/cloud-oauth.unknown-authorization-request.exception.ts +++ b/redisinsight/api/src/modules/cloud/auth/exceptions/cloud-oauth.unknown-authorization-request.exception.ts @@ -7,7 +7,7 @@ export class CloudOauthUnknownAuthorizationRequestException extends HttpExceptio const response = { message, statusCode: HttpStatus.BAD_REQUEST, - error: 'CloudOauthGithubEmailPermission', + error: 'CloudOauthUnknownAuthorizationRequest', errorCode: CustomErrorCodes.CloudOauthUnknownAuthorizationRequest, };