OP: update homebrew installation instructions for ROS #2237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
andy-stark-redis
approved these changes
Oct 15, 2025
Contributor
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
LGTM - just one observation to consider, but feel free to ignore it :-)
| rm -iv $(brew --prefix)/etc/redis.conf | ||
| ``` | ||
|
|
||
| Next, follow the instructions in the [next section](#install-using-homebrew) to install Redis Open Source 8.x using the Redis Homebrew cask. After installation and starting Redis, you can test to see if all the modules are loaded correctly by running the following command. |
Contributor
There was a problem hiding this comment.
Just wondering, does this module check make more sense in the "Connect to Redis" section? If there's a reason to put it here then no problem, but it would seem to follow on naturally as part of the stuff about redis-cli.
Collaborator
Author
There was a problem hiding this comment.
I agree. I was up last night thinking about this very thing. I've fixed this in the most recent push. Please take another look if you don't mind.
andy-stark-redis
approved these changes
Oct 15, 2025
Contributor
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
Yeah, I'd say it looks better like that. J'approve!
Collaborator
Author
|
Thank you, @andy-stark-redis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.