Fix sidebar auto-scroll to correctly target scrollable container #2245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use closest() to find the actual scrollable UL container - Calculate position relative to the scrollable container, not the sidebar - Use getBoundingClientRect() for accurate positioning - Position active link near the top with 20px padding for visibility - Fixes issue where scroll didn't work correctly for Develop/Operate/Integrate - Fixes Commands section scrolling too far This improves the previous implementation by targeting the correct overflow-y-auto UL element that actually scrolls, rather than trying to scroll the sidebar nav element itself.
Contributor
andy-stark-redis
approved these changes
Oct 16, 2025
Contributor
andy-stark-redis
left a comment
andy-stark-redis
left a comment
There was a problem hiding this comment.
Tested sidebar and in-page links, and directly pasting a URL into the URL bar - all seem to be working fine for all sections of the docs. Definitely approved :-)
rrelledge
approved these changes
Oct 16, 2025
Collaborator
rrelledge
left a comment
rrelledge
left a comment
There was a problem hiding this comment.
Thank you! I tested the RS section, and it looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the previous implementation by targeting the correct overflow-y-auto UL element that actually scrolls, rather than trying to scroll the sidebar nav element itself.