fix(extra/redisotel): set span.kind attribute to client #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks. Could you please fix the commit message? https://www.conventionalcommits.org/en/v1.0.0/ |
kristinnardal2
changed the title
Contributor
Author
|
I've changed the pull request message, It seems to however be complaining about the actual commit message, I would have to do a force push if I need to fix that. |
Collaborator
Yes, you need to force-push. We use commit messages to auto-generate the changelog. |
According to the opentelemetry specification this should always be set to client for database client libraries. I've also removed the SetAttributes call and instead set the attributes during creation of the span. This is what the library SHOULD be doing according to the opentelemetry api specification.
Contributor
Author
|
I've fixed the commit message and force pushed. |
kristinnardal2
changed the title
Collaborator
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the opentelemetry specification this should always be set
to client for database client libraries.
I've also removed the SetAttributes call and instead set the attributes
during creation of the span. This is what the library SHOULD be doing
according to the opentelemetry api specification.