Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

va_copy must be followed by va_end #178

Merged
merged 1 commit into from

2 participants

@rfuchs

... otherwise memory leak might result.

@pietern pietern merged commit 17d73ef into redis:master

1 check passed

Details default The Travis CI build passed
@pietern pietern referenced this pull request in antirez/redis
Closed

Minor issue: va_copy must be matched by va_end #1187

@mattsta mattsta referenced this pull request from a commit in mattsta/redis
@pietern pietern va_copy must be matched by va_end
Hat tip to @rfuchs. See: redis/hiredis#178.

Fixes #1187
90f0afe
@mattsta mattsta referenced this pull request from a commit in mattsta/redis
@pietern pietern va_copy must be matched by va_end
Hat tip to @rfuchs. See: redis/hiredis#178.

Fixes #1187
c3db4f7
@mattsta mattsta referenced this pull request from a commit in mattsta/redis
@pietern pietern va_copy must be matched by va_end
Hat tip to @rfuchs. See: redis/hiredis#178.

Fixes #1187
9e3e5c1
@pietern pietern referenced this pull request from a commit in antirez/redis
@pietern pietern va_copy must be matched by va_end
Hat tip to @rfuchs. See: redis/hiredis#178.

Fixes #1187
cf85b5b
@pietern pietern referenced this pull request from a commit in antirez/redis
@pietern pietern va_copy must be matched by va_end
Hat tip to @rfuchs. See: redis/hiredis#178.

Fixes #1187
327831e
@pietern pietern referenced this pull request from a commit in antirez/redis
@pietern pietern va_copy must be matched by va_end
Hat tip to @rfuchs. See: redis/hiredis#178.

Fixes #1187
f89a7bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 2, 2013
  1. @rfuchs
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  sds.c
View
1  sds.c
@@ -178,6 +178,7 @@ sds sdscatvprintf(sds s, const char *fmt, va_list ap) {
buf[buflen-2] = '\0';
va_copy(cpy,ap);
vsnprintf(buf, buflen, fmt, cpy);
+ va_end(cpy);
if (buf[buflen-2] != '\0') {
free(buf);
buflen *= 2;
Something went wrong with that request. Please try again.