Add helpers to Jedis pool

[oscar-besga-panel]

This mininal chage of code will allow to use Jedis connections without making a try/catch

Before

    try (Jedis jedis = jedisPool.getResource()) {
      //some code
       jedis.setnx("hello", "there");
      //some code
    }

After

jedisPool.withResource( (jedis) -> {
      //some code
       jedis.setnx("hello", "there");
      //some code
 });

Cleaner in my opinion

[jit-ci]

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

[oscar-besga-panel]

retest

[ggivo]

@oscar-besga-panel
Did you consider JedisPooled? It is available starting with Jedis 4 and helps to avoid a try-with-resources block for each command.

https://redis.io/docs/latest/develop/clients/jedis/connect/#connect-with-a-connection-pool

[ggivo]

Looks good in general,

needs unit tests to verify the resource is returned to the pool, on success, on error.

[ggivo]

I suggest :
Rename withJedisPoolGet → withResource

[oscar-besga-panel]

See bellow

[ggivo]

make sense. let's keep withResource/withResourceGet

[ggivo]

I suggest :
Rename withJedisPoolDo → withResource

[oscar-besga-panel]

The problem is if the two methods are renamed equally this won't compile

        withResource(jedis -> jedis.set("c"));
        String x = withResource(jedis -> jedis.get("c")); 

as it will trigger ambiguous method call in both lines.
Even if I like your idea, Java won't allow
(if you use a full body lambda it will make it, but that will reducefuture uses of the methods)

I'll suggest withResource and withResourceGet

[oscar-besga-panel]

@oscar-besga-panel Did you consider JedisPooled? It is available starting with Jedis 4 and helps to avoid a try-with-resources block for each command.

https://redis.io/docs/latest/develop/clients/jedis/connect/#connect-with-a-connection-pool

Yes, but I use JedisPool in my library for now.
(considering change as is Legacy but not deprecated)

JedisPooled is 99% the times better, except if you want to send multiple commands. then it will be getting/closing a pooled connection for every one.
Well you can use MULTI/EXEC or pipeline, thougth

[oscar-besga-panel]

I'm considering extending JedisPooled to be compatible with JedisPool by making it return a Jedis object... but not for now; and I know it has serious challenges.
If it is to be done, in another PR

[ggivo]

I'm considering extending JedisPooled to be compatible with JedisPool by making it return a Jedis object... but not for now; and I know it has serious challenges. If it is to be done, in another PR

I wouldn't go that way. JedisPooled is based on UnifiedJedis. Let's discuss this separately.

[ggivo]

@oscar-besga-panel
Did a bit of unit test clean up; other than that, the change looks good to me. Let me know if you plan more changes or we are good to go and merge it once test's are green

[oscar-besga-panel]

It looks good to me, merge when appropiate.
edit: typo

[ggivo]

LGTM

[oscar-besga-panel]

Thanks

[ggivo]

@oscar-besga-panel

Thanks a lot for the PR and the cleanup — appreciate the time and effort you put into this.Thanks for the contribution!