Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COMMAND LIST #1948

Closed
Tracked by #1813
chayim opened this issue Feb 13, 2022 · 2 comments · Fixed by #2149
Closed
Tracked by #1813

Add support for COMMAND LIST #1948

chayim opened this issue Feb 13, 2022 · 2 comments · Fixed by #2149
Assignees
Labels
feature New feature

Comments

@chayim
Copy link
Contributor

chayim commented Feb 13, 2022

No description provided.

@chayim chayim added this to To do in Redis 7 Support Feb 13, 2022
@chayim chayim added the feature New feature label Feb 13, 2022
@dogukanteber
Copy link
Contributor

dogukanteber commented Feb 15, 2022

Hello @chayim. I would like to work on this issue. However, I have a question. How can I test this command? Since it returns all the commands I thought maybe I can get the number of commands and compare them. For instance, currently, I get 363 different commands. Assume I do this operation len("command list") == 363 and in the next version there is another command added. So, the command number is up to 364 and the test fails.

I could not think of a way to test this. Can you give me any advice?

@chayim
Copy link
Contributor Author

chayim commented Feb 22, 2022

@dogukanteber I think the right answer is to check that we receive a number of commands that's positive and high - as opposed to a specific number. The reason: redis will constantly change, but we'll keep trying to support as many versions as possible!

Ultimately we're trying to test each collection of possibilities. I think this means you need one function that that makes repeated calls and uses r (the stock connection) and another that uses the redismod client. Does that make sense?

Here's the direct link to the new command.
CC: @dvora-h for visibility.

@dvora-h dvora-h moved this from To do to In progress in Redis 7 Support May 1, 2022
@chayim chayim moved this from In progress to Done in Redis 7 Support Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
Development

Successfully merging a pull request may close this issue.

2 participants